Grpc get localhost certificate programically #4212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aae6ef2.
Instead of having it copied from within the go stdlib which broke after golang/go@6783377
|
This also reverts #4211 as this now fixes the specific issue. |
inancgumus
approved these changes
Jan 21, 2025
ankur22
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Get the localhost certificate programatically instead of having a hard copy of it from within stdlib
Why?
This localhost certificate was update in golang/go@6783377 and this broke this tests in a none obvious way.
Big part of the problem is that the
httpteststdlib package always use the in stdlib certificate.But this test had a copy of this, but it is not obvious that the problem was this Certificate instead of something else.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)