feat: Add data files support #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
previously approved these changes
Feb 27, 2025
| `} | ||
| > | ||
| <Table.Cell>{file.name}</Table.Cell> | ||
| <Table.Cell>Unique item per iteration</Table.Cell> |
There was a problem hiding this comment.
Maybe Random item per iteration is a bit more clear?
There was a problem hiding this comment.
It's not random 😬 it picks array values based on scenario.iterationInTest as described here. I'll try to come up with better copy
Comment on lines
+114
to
+117
| <Tooltip | ||
| content="Data file is referenced in a rule" | ||
| hidden={!isFileInUse} | ||
| > |
going-confetti
commented
Mar 3, 2025
| <Table.ColumnHeaderCell | ||
| key={prop} | ||
| uppercase={false} | ||
| maxWidth="300px" |
There was a problem hiding this comment.
Added maxWidth to table columns to make sure it will look decent even with longer string values
Llandy3d
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363 #507
Description
Add support for data files in parameterization (and custom code) rules. This is the first iteration of the feature.
Known issues
How to Test
Screenshots (if appropriate):