fix: docker-compose env issue & update readme #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
novalagung
commented
Feb 1, 2024
- fix: error OTEL_EXPORTER_OTLP_TRACES_INSECURE contains true, which is an invalid type, it should be a string, number, or a null
- fix: incorrect MLT dashboard URL
… an invalid type, it should be a string, number, or a null
|
|
hedss
approved these changes
Feb 16, 2024
| @@ -58,7 +58,7 @@ To execute the environment and login: | |||
| ``` | |||
| - "3123:3000" | |||
| ``` | |||
| 3. Navigate to the [MLT dashboard](http://localhost:3000/d/4VSk5Lank/mlt-dashboard?orgId=1&refresh=5s). | |||
| 3. Navigate to the [MLT dashboard](http://localhost:3000/d/ed4f4709-4d3b-48fd-a311-a036b85dbd5b/mlt-dashboard?orgId=1&refresh=5s). | |||
|
A note about Practically, it absolutely doesn't matter. The variables are unmarshalled as shell variables, not YAML, and the shell will deal with, and pass, the value in exactly the same way. If there was a space in it, that'd get into globbing rules, but we won't go there. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.