VizLegend: Implement natural sort, simplify, optimize #78570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
commented
Nov 23, 2023
Comment on lines
+942
to
+945
| [0, 0, 0, "Do not use any type assertions.", "0"], | ||
| [0, 0, 0, "Do not use any type assertions.", "1"], | ||
| [0, 0, 0, "Do not use any type assertions.", "2"], | ||
| [0, 0, 0, "Do not use any type assertions.", "3"] |
There was a problem hiding this comment.
i'm not sure how to TS my way out of this without adding unnecessary runtime coercion code 😢
adela-almasan
approved these changes
Nov 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative approach to #78494
legend-calcs.json
{ "annotations": { "list": [ { "builtIn": 1, "datasource": { "type": "grafana", "uid": "-- Grafana --" }, "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "target": { "limit": 100, "matchAny": false, "tags": [], "type": "dashboard" }, "type": "dashboard" } ] }, "editable": true, "fiscalYearStartMonth": 0, "graphTooltip": 0, "id": 588, "links": [], "liveNow": false, "panels": [ { "datasource": { "type": "grafana-testdata-datasource", "uid": "PD8C576611E62080A" }, "fieldConfig": { "defaults": { "color": { "mode": "palette-classic" }, "custom": { "axisBorderShow": false, "axisCenteredZero": false, "axisColorMode": "text", "axisLabel": "", "axisPlacement": "auto", "barAlignment": 0, "drawStyle": "line", "fillOpacity": 0, "gradientMode": "none", "hideFrom": { "legend": false, "tooltip": false, "viz": false }, "insertNulls": false, "lineInterpolation": "linear", "lineWidth": 1, "pointSize": 5, "scaleDistribution": { "type": "linear" }, "showPoints": "auto", "spanNulls": false, "stacking": { "group": "A", "mode": "none" }, "thresholdsStyle": { "mode": "off" } }, "mappings": [], "thresholds": { "mode": "absolute", "steps": [ { "color": "green", "value": null }, { "color": "red", "value": 80 } ] } }, "overrides": [] }, "gridPos": { "h": 23, "w": 17, "x": 0, "y": 0 }, "id": 2, "maxDataPoints": 10, "options": { "legend": { "calcs": [ "last", "first", "mean" ], "displayMode": "table", "placement": "right", "showLegend": true }, "tooltip": { "mode": "single", "sort": "none" } }, "targets": [ { "datasource": { "type": "grafana-testdata-datasource", "uid": "PD8C576611E62080A" }, "noise": 1000, "refId": "A", "scenarioId": "random_walk", "seriesCount": 30, "spread": 100 } ], "title": "Panel Title", "type": "timeseries" } ], "refresh": "", "revision": 1, "schemaVersion": 39, "tags": [], "templating": { "list": [] }, "time": { "from": "now-6h", "to": "now" }, "timepicker": {}, "timezone": "", "title": "legend-calcs", "uid": "qXFG4jT4k", "version": 5, "weekStart": "" }may be easiest to review each commit by itself. also hide whitespace changes: