Thanks, I will have a look at it.

@novalagung Would you be able to fix the failing tests?

@aknuds1 sure

@aknuds1 I just pushed some updates. all tests are passed now

@novalagung Great, how did you fix the tests? I can't tell from the diff.

@aknuds1 actually my changes did not touch the test codes at all. I only modified the go dotfiles and import paths. but somehow it causes the test to fail.

Then I performed the go mod tidy && go mod vendor again, push it and the test result back to normal (all passed). I believe the version of the xorm is the one causing the problem

@novalagung I found that the very last version of xorm (0.8.2) causes tests to fail. I am able to upgrade to 0.8.1 though, while your PR is on 0.8.0. I'm going to push my changes to your branch.

@aknuds1 sure, thank you

I'd like to hear from my team mates before merging it, hopefully they can chime in.

@novalagung I'm unable to reproduce your issue BTW:

➜  ~ go get -u github.com/grafana/grafana/pkg/tsdb 
➜  ~ 

It doesn't seem right to me either that an old version of github.com/go-xorm/core should change its module path?

the error only occur when go get performed inside go module.

➜  ~ mkdir app
➜  ~ cd app
➜  ~ go mod init app
➜  ~ go get -u github.com/grafana/grafana/pkg/tsdb

go: finding github.com/grafana/grafana/pkg latest
go: finding github.com/grafana/grafana/pkg/tsdb latest
...
go: github.com/grafana/grafana/pkg/tsdb imports
        github.com/go-xorm/core: github.com/go-xorm/core@v0.6.3: parsing go.mod:
        module declares its path as: xorm.io/core
                but was required as: github.com/go-xorm/core

@marefr What's your take on this, since you said there have been troubles upgrading xorm in the past. Would you want for this PR to upgrade only to the first xorm version (0.8.0) after their module path changed (to xorm.io/xorm)?

@aknuds1 I'm a bit skeptic accepting this for the sake of supporting using tsdb package as dependency since there's not a problem currently for Grafana . We have had a lot of problems related to upgrading xorm historically with hidden breaking changes and upgrading needs detailed comparison/review of all their changes. If you still want to upgrade I agree that upgrading to the lowest version first is the way to go, but still detailed comparison/review of all their changes (all xorm packages that Grafana uses) is needed.

@novalagung out of curiosity what are you using Grafana's tsdb package for?

@marefr Thanks for the clarification! I guess we should make it a future task for ourselves to go through the paces of upgrading xorm, including reviewing and testing. At the time being, I figure it's not enough of a priority.

@marefr actually I didn't use tdsb package exclusively on my work. I found out about the issue when I was stumble upon in stackoverflow, looking for recent unanswered questions. I found the issue and then decide to test it.

All committers have signed the CLA.

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

I merged with latest Grafana master and pushed to your repo. Will merge it once the checks finish :)

@marefr @aknuds1 thank you

@novalagung Thank you for contributing to Grafana!