Skip to content

Alerting: Add rule group name validation to the Prometheus conversion API #108740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

Alerting: Add rule group name validation to the Prometheus conversion API #108740

merged 1 commit into from
Jul 28, 2025

Conversation

alexander-akhmetov
Copy link
Contributor

@alexander-akhmetov alexander-akhmetov commented Jul 26, 2025 •
edited
Loading

What is this feature?

Adds rule group name validation to the the Alerting Prometheus conversion API. Currently it's possible to send a rule group with an empty name, and this PR makes this impossible.

Also improves error handling in the conversion API by propagating error messages to API responses.

@github-project-automation github-project-automation bot moved this to In review in Alerting Jul 26, 2025
@alexander-akhmetov alexander-akhmetov added no-changelog Skip including change in changelog/release notes add to changelog and removed no-changelog Skip including change in changelog/release notes labels Jul 26, 2025
@alexander-akhmetov alexander-akhmetov marked this pull request as ready for review July 26, 2025 22:04
@alexander-akhmetov alexander-akhmetov requested a review from a team as a code owner July 26, 2025 22:04
@alexander-akhmetov alexander-akhmetov changed the title Alerting: Add rule group name validation to the conversion API Alerting: Add rule group name validation to the Prometheus conversion API Jul 27, 2025
@alexander-akhmetov alexander-akhmetov added the backport v12.1.x Mark PR for automatic backport to v12.1.x label Jul 28, 2025
@alexander-akhmetov alexander-akhmetov merged commit f969eb0 into main Jul 28, 2025
123 checks passed
@alexander-akhmetov alexander-akhmetov deleted the alexander-akhmetov/validate-group-name branch July 28, 2025 09:44
@github-project-automation github-project-automation bot moved this from In review to Done in Alerting Jul 28, 2025
grafana-delivery-bot bot pushed a commit that referenced this pull request Jul 28, 2025
@alexander-akhmetov @github-actions
Alerting: Add rule group name validation to the Prometheus conversion…
88a3f2a 
… API (#108740)

Alerting: Add rule group name validation to the conversion API
(cherry picked from commit f969eb0)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Jul 28, 2025
Merged
alexander-akhmetov added a commit that referenced this pull request Jul 28, 2025
@grafana-delivery-bot @alexander-akhmetov
[release-12.1.1] Alerting: Add rule group name validation to the Prom…
302e956 
…etheus conversion API (#108767)

Alerting: Add rule group name validation to the Prometheus conversion API (#108740)

Alerting: Add rule group name validation to the conversion API
(cherry picked from commit f969eb0)

Co-authored-by: Alexander Akhmetov <me@alx.cx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fayzal-g fayzal-g fayzal-g approved these changes

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend backport v12.1.x Mark PR for automatic backport to v12.1.x
Projects
Alerting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-akhmetov @fayzal-g