Alerting: Filter out synthetic datasource-managed rules when importing to GMA #106358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
96e5cc3 to
3b559ec
Compare
This comment has been minimized.
This comment has been minimized.
konrad147
reviewed
Jun 5, 2025
public/app/features/alerting/unified/components/import-to-gma/ConfirmConvertModal.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/import-to-gma/ConfirmConvertModal.tsx
Outdated
Show resolved
Hide resolved
YannickAlex07
pushed a commit
to YannickAlex07/grafana
that referenced
this pull request
Jul 11, 2025
…g to GMA (grafana#106358) * filter out synthetic datasource-managed rules when importing to GMA through the UI * address pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds additional filter when importing datasource-managed rules through the UI.
It skips rules from synthetics monitoring see more context here
Why do we need this feature?
Rules managed by plugins should not be imported. Synthetics rules don't use the
__grafana_originto indicate that they are managed by a plugin, so we need to filtering out these rules differently.Who is this feature for?
Alerting users.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Please check that: