Auth: Remove code for authenticating API keys #105998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyongyosi
approved these changes
May 28, 2025
YannickAlex07
pushed a commit
to YannickAlex07/grafana
that referenced
this pull request
Jul 11, 2025
* remove auth for plain API keys * move condition to validateApiKey() * fix typo * remove GetApiKeyById() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the code for authenticating using plain API keys. Plain API keys are the ones that don't belong to a service account. The API keys that do belong to a service account (these are called service account tokens) will continue to work after the changes from this PR.
Why do we need this feature?
All API keys have been forced migrated to service accounts for all Grafana instances. Now we want to stop API keys (although none should exist anymore) from authenticating.
Who is this feature for?
all users
Which issue(s) does this PR fix?:
Part of #53567.
Special notes for your reviewer:
Please check that: