Skip to content

fix: Updated promtail arch map for aarch64 matching #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: Updated promtail arch map for aarch64 matching #257

merged 2 commits into from
Aug 13, 2024

Conversation

gianmarco-mameli
Copy link
Contributor

Hi, I've used the collection to install promtail on a couple of Arm64 vms and I found that the machine architecture for the promtail installation is not mapped to arm64, to permit matching on the file to download.
The role tried to download the file with suffix aarch64 but the correct one is arm64, so I committed the updated promtail architecture map, also including 2 variations for old Raspberrys

__promtail_arch_map:
  x86_64: amd64
  armv6l: arm
  armv7l: arm
  aarch64: arm64

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gianmarco-mameli gianmarco-mameli changed the title Updated promtail arch map for aarch64 matching fix: Updated promtail arch map for aarch64 matching Aug 13, 2024
voidquark
voidquark reviewed Aug 13, 2024
View reviewed changes
@voidquark
Copy link
Collaborator

voidquark commented Aug 13, 2024 •
edited
Loading

Hi, I've used the collection to install promtail on a couple of Arm64 vms and I found that the machine architecture for the promtail installation is not mapped to arm64, to permit matching on the file to download. The role tried to download the file with suffix aarch64 but the correct one is arm64, so I committed the updated promtail architecture map, also including 2 variations for old Raspberrys

__promtail_arch_map:
  x86_64: amd64
  armv6l: arm
  armv7l: arm
  aarch64: arm64

Could you please apply the same changes to the Loki role as well?

@gianmarco-mameli
Copy link
Contributor Author

yeah no problem

voidquark
voidquark approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@voidquark voidquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Approved.

@voidquark voidquark merged commit cdc1746 into grafana:main Aug 13, 2024
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidquark voidquark voidquark approved these changes

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianmarco-mameli @CLAassistant @voidquark