Skip to content

Conversation

ljacomet
Copy link
Member

It might be easier to review per commit.

@ljacomet ljacomet added the a:chore Minor issue without significant impact label Nov 21, 2022
@ljacomet ljacomet added this to the 8.0 RC1 milestone Nov 21, 2022
@ljacomet ljacomet requested a review from a team November 21, 2022 17:33
@ljacomet ljacomet requested a review from a team as a code owner November 21, 2022 17:33
@ljacomet ljacomet self-assigned this Nov 21, 2022
@ljacomet ljacomet requested a review from jvandort November 21, 2022 17:33
Copy link
Member

@jvandort jvandort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not comfortable enough with tooling API to review those changes, but everything else LGTM

`maven` plugins was removed in 7 but the class was kept for plugins
using `withPlugins(MavenPlugin)`

* Spring Boot plugin in snippets and samples updated
* Shadow plugin supported versions updated
@ljacomet ljacomet force-pushed the ljacomet/deprecation/remove-deprecated-tooling-api branch from a9738d7 to e371331 Compare November 21, 2022 19:51
@ljacomet
Copy link
Member Author

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

@jbartok jbartok self-assigned this Nov 22, 2022
Copy link
Member

@jbartok jbartok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbartok jbartok removed their assignment Nov 22, 2022
@ljacomet
Copy link
Member Author

@bot-gradle test and merge

@gradle gradle deleted a comment from ljacomet Nov 22, 2022
@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit def87d6 into master Nov 22, 2022
@ljacomet ljacomet deleted the ljacomet/deprecation/remove-deprecated-tooling-api branch November 22, 2022 16:50
@aSemy aSemy mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants