Re-use Scala compiler between runs #20580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Thanks for the PR. Do we need to add tests? |
JLLeitschuh
reviewed
Apr 27, 2022
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
donat
requested changes
Apr 28, 2022
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
alpar-t
reviewed
May 2, 2022
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
|
@donat can you please take a look at the latest changes? |
donat
requested changes
May 6, 2022
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/api/tasks/scala/ScalaCompile.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/api/tasks/scala/ScalaCompile.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Show resolved
Hide resolved
donat
reviewed
May 6, 2022
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/AbstractScalaCompile.java
Outdated
Show resolved
Hide resolved
|
@bot-gradle test rfm please |
|
OK, I've already triggered the following builds for you: |
|
@donat is there a doc on the release schedule for gradle ? I would like to know when this will be available. Also, do we have a process for backporting the fix to a previous release? |
|
@donat any updates on getting this merged? |
|
@donat any updates on merging this PR ? |
|
The changes unearthed an internal issue. I started investigating a couple of days ago but I got dragged into another task. Nonetheless, you can expect this feature to be part of Gradle 7.6. |
Signed-off-by: Ashwin Pankaj <apankaj@confluent.io>
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
donat
approved these changes
May 31, 2022
bot-gradle
added a commit
that referenced
this pull request
Jul 21, 2022
…ptions.keepAliveMode property #20580 introduced `keepAliveOption`. The changes work fine, although a few things are missing, fixed by this PR: - Add test coverage - Rename keepAliveOption to keepAliveMode - Get ObjectFactory reference once per AbstractScalaCompile constructor - Set convention value in ScalaBasePlugin class - Use enum property to enforce configuration time validation errors Co-authored-by: Donat Csikos <donat@gradle.com>
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20579
Signed-off-by: Ashwin Pankaj apankaj@confluent.io