Skip to content

Conversation

martiliones
Copy link

Add support for commands in messages with photo, files etc

Add support for commands in messages with photo, files etc
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

This is a breaking change:

bot.command('start', ctx => {
  // The PR breaks this:
  const text = ctx.msg.text
})

I am happy to merge this for a 2.0 release. However, there are a lot of things to do before a 2.0 release makes sense, so this PR will have to remain open for months.

That being said, this only takes so much time because I am the only one actively working on the core package. Lots of people review my work and try out new features, but only very few actively work on features. For example, if someone else could take responsibility for #136, I could put more time into the core again. Naturally, I also appreciate a lot if anyone wants to help out with #109!

If the composer code was to change, you do not need to update this PR. I will ping you when this becomes relevant again, i.e. when work on 2.0 begins.

Co-authored-by: KnorpelSenf <shtrog@gmail.com>
@KnorpelSenf
Copy link
Member

Backed by the community in https://t.me/grammyjs/36850

@KnorpelSenf KnorpelSenf changed the title Add support for commands in messages with media feat: add support for commands in messages with media May 29, 2022
@roziscoding
Copy link
Contributor

This functionality is available via the Commands Plugin, if anyone needs to use it now :)

@martiliones martiliones closed this by deleting the head repository Aug 11, 2024
@KnorpelSenf
Copy link
Member

Why close it? I was still planning on merging this for 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants