We can wrap update with Promise.allSettled in framework handlers and gracefully stop Update processing. Like:

update type:

Promise<[PromiseSettledResult<Update>]>

if (header !== secretToken) {
    await unauthorized();
    // TODO: investigate deno bug that happens when this console logging is removed
    console.log(handlerReturn);
    return handlerReturn;
}

const [updateData] = await update;
if (updateData.status === "rejected") {
    await badRequest();
    console.log(handlerReturn);
    return handlerReturn;
}

let usedWebhookReply = false;
const webhookReplyEnvelope: WebhookReplyEnvelope = {
    async send(json) {
        usedWebhookReply = true;
        await respond(json);
    },
};
await timeoutIfNecessary(
    bot.handleUpdate(updateData.value, webhookReplyEnvelope),
    typeof onTimeout === "function"
        ? () => onTimeout(...args)
        : onTimeout,
    timeoutMilliseconds,
);

Answer with bad request feels right, but we need to introduce this extra callback in every framework handler then.

As an alternative, we can make update type

Update

Most of handlers will remove Promise.resolve(). The rest will have to safely resolve promise like:

await c.req.json().catch(() => ({}))

then we can check it in webhookCallback by if (!update.update_id)

feat: make update in webhook adapters a function #697

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

feat: make `update` in webhook adapters a function #697