fix: use same code for all environments #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: no longer uses `os-name` in Node environment. The platform release version is no longer included. For example `"Node.js/10.21.0 (Linux 4.15; x64)"` is now `"Node.js/10.21.0 (Linux; x64)"
00641ee to
8f2d21f
Compare
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 24, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping for conditional exports support to arrive sooner to the popular build tools, but doesn't look like it. I decided that the value for having the additional userAgent information about OS release version is not worth all the trouble that people experience because of it. Simplicity ftw.
closes #38
fixes #23
fixes #35
fixes #37
fixes #52
fixes https://github.com/octokit/rest.js/issues/1781
BREAKING CHANGE: no longer uses
os-namein Node environment. The platformrelease version is no longer included. For example
"Node.js/10.21.0 (Linux 4.15; x64)"is now `"Node.js/10.21.0 (Linux; x64)"