fix: panic when setting bool via envvar #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ docker run -e GOTIFY_SERVER_SSL_ENABLED=true --rm gotify/server:2.6.0
Starting Gotify version 2.6.0@2024-11-15-19:19:19
panic: reflect.Set: value of type bool is not assignable to type *bool
goroutine 1 [running]:
reflect.Value.assignTo({0xf5e000?, 0x1c375a8?, 0x19?}, {0x108809b, 0xb}, 0xf42960, 0x0)
/usr/local/go/src/reflect/value.go:3358 +0x299
reflect.Value.Set({0xf42960?, 0xc0000cd200?, 0x4?}, {0xf5e000?, 0x1c375a8?, 0xf42960?})
/usr/local/go/src/reflect/value.go:2313 +0xe6
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xc0002eecc0?, 0xc0000cd200?}, {0xc0002ef0c0, 0x3, 0x4})
/go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:307 +0xc11
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xc0002eec80?, 0xc0000cd1e0?}, {0xc0002ad880, 0x2, 0x2})
/go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:330 +0xe79
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xf41420?, 0xc0000cd1e0?}, {0xc0002f0610, 0x1, 0x1})
/go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:330 +0xe79
github.com/jinzhu/configor.(*Configor).load(0xc0002f0270, {0xf41420, 0xc0000cd1e0}, 0x0, {0xc0002ad7a0?, 0x1c7c000?, 0xc0002ad7a0?})
/go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:415 +0x3f8
github.com/jinzhu/configor.(*Configor).Load(0xc0002f0270, {0xf41420, 0xc0000cd1e0}, {0xc0002ad7a0, 0x2, 0x2})
/go/pkg/mod/github.com/jinzhu/configor@v1.2.2/configor.go:92 +0x13c
github.com/gotify/server/v2/config.Get()
/src/gotify/config/config.go:69 +0xf3
main.main()
/src/gotify/app.go:34 +0x1e5
1d141ca to
6b3ff77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 56 56
Lines 2639 2639
=======================================
Hits 2096 2096
Misses 452 452
Partials 91 91 ☔ View full report in Codecov by Sentry. |
eternal-flame-AD
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
https://github.com/jinzhu/configor/blob/f7a0fc7c9fc697269b1749c1cc472d49baa8d33c/utils.go#L295
Seems like for some reason this is put before dereferencing the pointer. But this shouldn't need to be a pointer anyways so :)
M1cha
added a commit
to M1cha/homeserver
that referenced
this pull request
May 24, 2025
gotify: downgrade to 2.5 2.6 broke when using SSL: - gotify/server#734 - gotify/server#731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know exactly what the problem is, but not having pointers for the booleans seem to help and they seem unnecessary.
See #731 (comment)
Is an upstream issue: jinzhu/configor#92