Skip to content

Duration order consistency when multiplying number by time unit #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

Duration order consistency when multiplying number by time unit #570

merged 1 commit into from
Mar 19, 2020

Conversation

maxifom
Copy link
Contributor

@maxifom maxifom commented Jan 11, 2020

Fixes #

Summary of Changes

  1. Fixed duration order consistency when multiplying number by time unit in conn.go

ferhatelmas
ferhatelmas suggested changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consistency change.

ferhatelmas
ferhatelmas approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consistency change.

@elithrar elithrar merged commit d113569 into gorilla:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
4 more reviewers

@elithrar elithrar elithrar approved these changes

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@ekrem95 ekrem95 ekrem95 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxifom @elithrar @ferhatelmas @ekrem95