Skip to content

examples/chat/client.go: avoid allocating []byte{} for PingMessage #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Dec 10, 2017
Merged

examples/chat/client.go: avoid allocating []byte{} for PingMessage #312

1 commit merged into from
Dec 10, 2017

Conversation

JordanP
Copy link
Contributor

@JordanP JordanP commented Dec 9, 2017

It's useless and only gives more work to the GC.

@JordanP
examples/chat/client.go: avoid allocating []byte{} for PingMessage
2882200 
It's useless and only gives more work to the GC.
@ghost
Copy link

ghost commented Dec 9, 2017 •
edited by ghost
Loading

[]byte{} does not allocate memory. I'll merge because the code is simpler.

@ghost ghost merged commit cdedf21 into gorilla:master Dec 10, 2017
@JordanP JordanP deleted the patch-1 branch December 10, 2017 10:05
@ghost ghost locked and limited conversation to collaborators Aug 29, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JordanP