Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2017

No description provided.

@ghost ghost mentioned this pull request Feb 6, 2017
@ghost
Copy link
Author

ghost commented Feb 6, 2017

Work to be done:

  • Simplify or remove the benchmarks.
  • Pool the fake connection write buffer. Better yet, refactor connection code to eliminate use of fake connection.
  • Add autobahn test w/ prepared messages.

@FZambia
Copy link
Contributor

FZambia commented Feb 13, 2017

@garyburd waiting for feedback on what I've pushed.

Pool the fake connection write buffer.

Is it the same as #192 ? This looks like optimization but not a requirement.

Better yet, refactor connection code to eliminate use of fake connection.

Not sure I am ready to take over on this as it seems like dangerous refactoring if done by me:)

Simplify broadcast benchmarks, autobahn tests for prepared message
@ghost ghost merged commit 804cb60 into gorilla:master Feb 14, 2017
@ghost
Copy link
Author

ghost commented Feb 14, 2017

@FZambia Thank you for helping to get this done.

@ghost ghost locked and limited conversation to collaborators Feb 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants