Skip to content

Added capacity to slice creation, when capacity is known #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Added capacity to slice creation, when capacity is known #516

merged 1 commit into from
Aug 30, 2019

Conversation

vivekv96
Copy link
Contributor

Simple optimisation to reduce memory allocations and copying(while appending).

fharding1
fharding1 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@fharding1 fharding1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elithrar
elithrar approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vivekv96!

@elithrar elithrar self-assigned this Aug 30, 2019
@elithrar elithrar merged commit 884b5ff into gorilla:master Aug 30, 2019
@srenatus srenatus mentioned this pull request Sep 20, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@elithrar elithrar elithrar approved these changes

@fharding1 fharding1 fharding1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@elithrar elithrar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekv96 @elithrar @fharding1