Skip to content

Replace 200, HEAD and OPTIONS with constants from net/http #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

Replace 200, HEAD and OPTIONS with constants from net/http #243

merged 1 commit into from
Aug 16, 2023

Conversation

iBug
Copy link
Contributor

@iBug iBug commented Aug 6, 2023 •
edited by coreydaley
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

A previous commit (#241) replaced most HTTP constants with those from standard library net/http, but some was missed. This PR catches 3 of them.

Related Tickets & Documents

  • Related Issue: None
  • Closes: None

Added/updated tests?

  • Yes
  • No, and this is why: Trivial changes, tests not required
  • I need help with writing tests

Run verifications and test

  • make verify is passing (which I believe is not my fault)
  • make test is passing

@coreydaley coreydaley self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #243 (295a81b) into main (0eda2fc) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files           7        7           
  Lines         598      598           
=======================================
  Hits          505      505           
  Misses         82       82           
  Partials       11       11
Files Changed Coverage Δ
cors.go 96.02% <ø> (ø)

@coreydaley
Copy link

@iBug Would you mind posting the results of the make verify that is not passing for you? Along with what Operating System and Go version that you are using?

@coreydaley coreydaley enabled auto-merge (squash) August 7, 2023 02:12
@iBug
Copy link
Contributor Author

iBug commented Aug 7, 2023

@coreydaley Ubuntu 22.04 LTS, Go 1.20.7.

With one exception (first one below), all errors are from files under /usr/local/go/src where my Go installation is located.

canonical_test.go:55:33: missing type in composite literal (typecheck)
        querystring := url.Values{"q": {"golang"}, "format": {"json"}}.Encode()
                                       ^
../../../../usr/local/go/src/runtime/debuglog.go:296:20: StringData not declared by package unsafe (typecheck)
        strData := unsafe.StringData(x)
                          ^
../../../../usr/local/go/src/runtime/heapdump.go:159:37: StringData not declared by package unsafe (typecheck)
        dumpmemrange(unsafe.Pointer(unsafe.StringData(s)), uintptr(len(s)))
                                           ^
../../../../usr/local/go/src/runtime/heapdump.go:202:32: StringData not declared by package unsafe (typecheck)
                dwrite(unsafe.Pointer(unsafe.StringData(pkgpath)), uintptr(len(pkgpath)))

However, if I do make verify inside a Docker container (image golang:1.20-bookworm), then everything's fine. I guess I can tick that checkbox now.

@coreydaley coreydaley merged commit fc93057 into gorilla:main Aug 16, 2023
@iBug iBug deleted the typos branch August 21, 2023 16:03
yurishkuro referenced this pull request in jaegertracing/jaeger Jun 12, 2024
@renovate
Update module github.com/gorilla/handlers to v1.5.2 (#5584)
965c538 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/gorilla/handlers](https://togithub.com/gorilla/handlers) |
`v1.5.1` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gorilla/handlers (github.com/gorilla/handlers)</summary>

###
[`v1.5.2`](https://togithub.com/gorilla/handlers/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/gorilla/handlers/compare/v1.5.1...v1.5.2)

#### What's Changed

- build: CircleCI 2.1 + build matrix by
[@&#8203;elithrar](https://togithub.com/elithrar) in
[https://github.com/gorilla/handlers/pull/199](https://togithub.com/gorilla/handlers/pull/199)
- Update README.md by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239)
- added makefile, github-actions and updated go version by
[@&#8203;bharat-rajani](https://togithub.com/bharat-rajani) in
[https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241)
- Update issues.yml by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/242](https://togithub.com/gorilla/handlers/pull/242)
- Replace 200, HEAD and OPTIONS with constants from net/http by
[@&#8203;iBug](https://togithub.com/iBug) in
[https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243)
- update GitHub workflows by
[@&#8203;coreydaley](https://togithub.com/coreydaley) in
[https://github.com/gorilla/handlers/pull/251](https://togithub.com/gorilla/handlers/pull/251)

#### New Contributors

- [@&#8203;coreydaley](https://togithub.com/coreydaley) made their first
contribution in
[https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239)
- [@&#8203;bharat-rajani](https://togithub.com/bharat-rajani) made their
first contribution in
[https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241)
- [@&#8203;iBug](https://togithub.com/iBug) made their first
contribution in
[https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243)

**Full Changelog**:
gorilla/handlers@v1.5.1...v1.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/jaegertracing/jaeger).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@coreydaley coreydaley coreydaley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@coreydaley coreydaley

Labels
size/XS
Projects
Gorilla Web Toolkit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iBug @coreydaley