Skip to content

Filter edits lost if switch tab in uBlock Dashboard #250

@Gitoffthelawn

Description

@Gitoffthelawn

If, after editing filters (but not pressing 'Apply changes'), the user switches the tab within the uBlock Dashboard, all edits will be lost.

Steps to Reproduce:

  1. Open uBlock Dashboard.
  2. Select 'My filters' tab.
  3. Edit one or more filters.
  4. Select any other tab in the uBlock Dashboard.
  5. Select 'My filters' tab.

Actual Results:
All edits in Step 3 above are lost.

Expected Results:
Either do not lose edits when switching tabs within uBlock Dashboard, or display a query box: 'Changing uBlock Dashboard tabs will discard changes. Apply changes?'

Test System: uBlock Origin 0.9.7.5, Firefox 38.0.1, Win7 SP1

Workaround:
The following can be applied to a local stylesheet to make the need to press the 'Apply changes' button more prominent.
/* 'Apply changes' button: increase width */

userFiltersApply { min-width: 300px; }

/* 'Apply changes' button: add prominent glow when a change has been made (switching dashboard tabs without applying loses changes) */

userFiltersApply:not([disabled]) { filter: drop-shadow(0px 0px 9px green); color: green; }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions