-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
If, after editing filters (but not pressing 'Apply changes'), the user switches the tab within the uBlock Dashboard, all edits will be lost.
Steps to Reproduce:
- Open uBlock Dashboard.
- Select 'My filters' tab.
- Edit one or more filters.
- Select any other tab in the uBlock Dashboard.
- Select 'My filters' tab.
Actual Results:
All edits in Step 3 above are lost.
Expected Results:
Either do not lose edits when switching tabs within uBlock Dashboard, or display a query box: 'Changing uBlock Dashboard tabs will discard changes. Apply changes?'
Test System: uBlock Origin 0.9.7.5, Firefox 38.0.1, Win7 SP1
Workaround:
The following can be applied to a local stylesheet to make the need to press the 'Apply changes' button more prominent.
/* 'Apply changes' button: increase width */
userFiltersApply { min-width: 300px; }
/* 'Apply changes' button: add prominent glow when a change has been made (switching dashboard tabs without applying loses changes) */