Use onmessage/postMessage instead of BroadcastChannel in diff updater

gorhill · gorhill · commit ea8853cda3ef · 2025-02-28T17:18:48.000-05:00
diff --git a/src/js/assets.js b/src/js/assets.js
@@ -1244,10 +1244,8 @@ async function diffUpdater() {
     ubolog('Diff updater: cycle start');
     return new Promise(resolve => {
         let pendingOps = 0;
-        const bc = new globalThis.BroadcastChannel('diffUpdater');
         const terminate = error => {
             worker.terminate();
-            bc.close();
             resolve();
             if ( typeof error !== 'string' ) { return; }
             ubolog(`Diff updater: terminate because ${error}`);
@@ -1260,14 +1258,15 @@ async function diffUpdater() {
             if ( metadata.diffPath === data.patchPath ) { return; }
             assetCacheSetDetails(data.assetKey, metadata);
         };
-        bc.onmessage = ev => {
+        const worker = new Worker('js/diff-updater.js');
+        worker.onmessage = ev => {
             const data = ev.data || {};
             if ( data.what === 'ready' ) {
                 ubolog('Diff updater: hard updating', toHardUpdate.map(v => v.assetKey).join());
                 while ( toHardUpdate.length !== 0 ) {
                     const assetDetails = toHardUpdate.shift();
                     assetDetails.fetch = true;
-                    bc.postMessage(assetDetails);
+                    worker.postMessage(assetDetails);
                     pendingOps += 1;
                 }
                 return;
@@ -1284,7 +1283,7 @@ async function diffUpdater() {
                     data.text = result.content || '';
                     data.status = undefined;
                     checkAndCorrectDiffPath(data);
-                    bc.postMessage(data);
+                    worker.postMessage(data);
                 });
                 return;
             }
@@ -1320,15 +1319,14 @@ async function diffUpdater() {
             if ( pendingOps === 0 && toSoftUpdate.length !== 0 ) {
                 ubolog('Diff updater: soft updating', toSoftUpdate.map(v => v.assetKey).join());
                 while ( toSoftUpdate.length !== 0 ) {
-                    bc.postMessage(toSoftUpdate.shift());
+                    worker.postMessage(toSoftUpdate.shift());
                     pendingOps += 1;
                 }
             }
             if ( pendingOps !== 0 ) { return; }
             ubolog('Diff updater: cycle complete');
             terminate();
         };
-        const worker = new Worker('js/diff-updater.js');
     }).catch(reason => {
         ubolog(`Diff updater: ${reason}`);
     });
diff --git a/src/js/diff-updater.js b/src/js/diff-updater.js
@@ -265,21 +265,21 @@ async function fetchAndApplyAllPatches(assetDetails) {
 
 /******************************************************************************/
 
-const bc = new globalThis.BroadcastChannel('diffUpdater');
+const self = globalThis;
 
-bc.onmessage = ev => {
+self.onmessage = ev => {
     const message = ev.data || {};
     switch ( message.what ) {
     case 'update':
         fetchAndApplyAllPatches(message).then(response => {
-            bc.postMessage(response);
+            self.postMessage(response);
         }).catch(error => {
-            bc.postMessage({ what: 'broken', error });
+            self.postMessage({ what: 'broken', error });
         });
         break;
     }
 };
 
-bc.postMessage({ what: 'ready' });
+self.postMessage({ what: 'ready' });
 
 /******************************************************************************/
