feat: srpm #935
Merged
feat: srpm #935
+130
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
8 tasks
Deploying nfpm with
|
| Latest commit: |
ce22b32
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66bdcb58.nfpm.pages.dev |
| Branch Preview URL: | https://srpm.nfpm.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
Adds support for building source RPMs (.src.rpm) alongside regular RPMs by introducing a new SRPM packager variant.
- Introduce
DefaultSRPMand extendRPMwith aformatfield to switch between binary and source RPM formats - Register both
"rpm"and"src.rpm"packagers and wire through.ConventionalExtension()and.Package() - Update all existing tests to target
DefaultRPM, and add a placeholderTestSRPMfor source RPM validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rpm/rpm.go | Add format enum, DefaultSRPM, tagSourcePackage, and switchable extension/packaging logic |
| rpm/rpm_test.go | Replace Default with DefaultRPM, inject TestSRPM, and adjust calls for the new packager |
Comments suppressed due to low confidence (2)
rpm/rpm.go:55
- [nitpick] Comment above
DefaultSRPMincorrectly referencesDefaultRPM. Update to// DefaultSRPM SRPM packager.for clarity.
// DefaultRPM RPM packager.
rpm/rpm_test.go:156
- The new
TestSRPMfunction is missing assertions for source‐RPM metadata and does not close its function body with a}before the next test. Add equivalent validation steps (e.g., checking for the source package tag) and a closing brace.
func TestSRPM(t *testing.T) {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 69.29% 69.28% -0.01%
==========================================
Files 22 22
Lines 3120 3129 +9
==========================================
+ Hits 2162 2168 +6
- Misses 745 747 +2
- Partials 213 214 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a
src.rpmpackager.refs goreleaser/goreleaser#3412