fix: symlink with empty mtime #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Deploying nfpm with
|
| Latest commit: |
3fbb22a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5172e764.nfpm.pages.dev |
| Branch Preview URL: | https://issue-952.nfpm.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
+ Coverage 69.39% 69.41% +0.01%
==========================================
Files 22 22
Lines 3140 3142 +2
==========================================
+ Hits 2179 2181 +2
Misses 747 747
Partials 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with symlinks that have empty modification times (mtime). The fix ensures that when a symlink's mtime is zero and the file cannot be stat'd (e.g., because it doesn't exist), the system uses the current time instead of leaving the mtime as zero.
- Modified the mtime handling logic to check both if the mtime is zero AND if the source file's mtime is non-zero
- Changed fallback behavior to use
time.Now()instead of the passedmtimeparameter when no valid mtime is available - Added comprehensive test coverage for the symlink scenario in both files and rpm modules
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| files/files.go | Updated mtime handling logic to properly handle symlinks with non-existent targets |
| files/files_test.go | Added test case to verify symlink mtime handling behavior |
| rpm/rpm_test.go | Added integration test to verify RPM packaging works correctly with symlinks having empty mtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #952