fix(docker/v2): properly set manifest annotations #6053
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the way manifest annotations are handled in Docker v2 builds by automatically prefixing annotation keys with index: when building multi-platform images.
- Automatically prefixes annotation keys with
index:for multi-platform builds - Updates tests to verify the annotation prefixing behavior
- Adds comprehensive integration tests for manifest annotation inspection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/pipe/docker/v2/docker.go | Implements the automatic index: prefix logic for multi-platform builds |
| internal/pipe/docker/v2/docker_test.go | Updates unit tests to verify annotation key prefixing |
| internal/pipe/docker/v2/docker_integration_test.go | Adds integration tests and helper functions for manifest inspection |
| .goreleaser.yaml | Adds sample annotation configuration for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| }, | ||
| }, | ||
| testctx.WithVersion("1.0.0"), | ||
| testctx.WithCurrentTag("v1.0.0"), | ||
| testctx.WithCommit("a1b2c3d4"), | ||
| testctx.WithSemver(1, 0, 0, ""), |
There was a problem hiding this comment.
The removal of testctx.WithCommit("a1b2c3d4") appears to be unintentional. This change could affect test reproducibility and should either be reverted or explained in the commit message.
| testctx.WithSemver(1, 0, 0, ""), | |
| testctx.WithSemver(1, 0, 0, ""), | |
| testctx.WithCommit("a1b2c3d4"), |
Copilot uses AI. Check for mistakes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6053 +/- ##
=======================================
Coverage 82.71% 82.72%
=======================================
Files 168 168
Lines 17173 17177 +4
=======================================
+ Hits 14205 14209 +4
Misses 2345 2345
Partials 623 623 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When we build a manifest, we need to prefix the annotation key with
index:.This does it automatically :)