Skip to content

feat(docker/v2): support arbitrary flags #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

feat(docker/v2): support arbitrary flags #6012

merged 1 commit into from
Aug 22, 2025

Conversation

caarlos0
Copy link
Member

needs #5793

@caarlos0 caarlos0 self-assigned this Aug 21, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 21, 2025 •
edited
Loading

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2311d59
Status: ✅  Deploy successful!
Preview URL: https://73645221.goreleaser.pages.dev
Branch Preview URL: https://flags.goreleaser.pages.dev

View logs

Base automatically changed from docker-v2 to main August 21, 2025 20:28
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.74%. Comparing base (1b0a0d7) to head (2311d59).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/pipe/docker/v2/docker.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6012      +/-   ##
==========================================
- Coverage   82.79%   82.74%   -0.05%     
==========================================
  Files         166      167       +1     
  Lines       16601    16937     +336     
==========================================
+ Hits        13744    14014     +270     
- Misses       2265     2316      +51     
- Partials      592      607      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caarlos0
feat(docker/v2): support arbitrary flags
2311d59 
needs #5793

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 21, 2025
@caarlos0 caarlos0 merged commit 72a00ef into main Aug 22, 2025
15 of 18 checks passed
@caarlos0 caarlos0 deleted the flags branch August 22, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarlos0