fix(cask): pass audit #5987
fix(cask): pass audit #5987
Conversation
- callers need to add the `url.verified` property if they want to pass
audit
- added the name which was missing
- I _think_ the problem with "unversioned url" is that it doesn't have
`#{version}` in it, if so, this should fix it I think
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
| Latest commit: |
49639e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16b54784.goreleaser.pages.dev |
| Branch Preview URL: | https://cask-audit.goreleaser.pages.dev |
|
cc/ @SMillerDev - can you take a look if my assumptions/fixes here are correct? thank you so much 🙏🏻 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5987 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 165 165
Lines 16568 16570 +2
=======================================
+ Hits 13711 13713 +2
Misses 2265 2265
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That's only needed if the download URL differs from the homepage URL.
Yeah, I think that triggers it. The main thing is that without a version in the URL we can't use a sha check because every update would override the existing artifact. |
yes, that's what i meant, sorry was not specific enough (it was 2am haha)
figured... these changes are good then? |
|
Yeah, lgtm |
|
Thanks @SMillerDev 🙏🏻 |
url.verifiedproperty if they want to pass audit#{version}in it, if so, this should fix it I thinkrefs https://github.com/orgs/goreleaser/discussions/5963