feat: retry docker manifest, retry configurations #5978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
3c0356c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64dbd8c1.goreleaser.pages.dev |
| Branch Preview URL: | https://retries.goreleaser.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5978 +/- ##
==========================================
+ Coverage 82.61% 82.75% +0.14%
==========================================
Files 165 165
Lines 16594 16568 -26
==========================================
+ Hits 13709 13711 +2
+ Misses 2290 2265 -25
+ Partials 595 592 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces centralized retry functionality using the avast/retry-go/v4 library to replace manual retry implementations across Docker operations and git cloning. The goal is to make retry configurations configurable for Docker images and manifests while standardizing retry behavior.
- Adds configurable retry settings for Docker images and manifests
- Replaces manual retry loops with the
avast/retry-golibrary - Standardizes retry behavior across Docker manifest creation, pushing, and git clone operations
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Adds avast/retry-go/v4 dependency |
| pkg/config/config.go | Adds Retry struct and integrates it into Docker and DockerManifest configs |
| www/docs/customization/docker.md | Documents new retry configuration for Docker push operations |
| www/docs/customization/docker_manifest.md | Documents new retry configuration for Docker manifest operations |
| internal/pipe/docker/docker.go | Replaces manual retry loop with retry-go library for Docker push operations |
| internal/pipe/docker/manifest.go | Adds retry functionality to manifest create and push operations |
| internal/pipe/docker/api_docker.go | Removes manual retry logic from Docker manifest creation |
| internal/pipe/release/release.go | Replaces manual retry loop with retry-go library for release uploads |
| internal/client/git.go | Replaces manual retry loop with retry-go library for git clone operations |
| internal/pipe/docker/docker_test.go | Adds tests for default retry configurations |
| internal/pipe/release/release_test.go | Updates test expectations for new error message format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5967
fixes #5853