Skip to content

feat(upload,artifactory): allow to set a password field, tmpl username #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2025
Merged

feat(upload,artifactory): allow to set a password field, tmpl username #5949

merged 4 commits into from
Aug 7, 2025

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 5, 2025

This, in conjunction with #5948, will allow users to read the password of a given artifactory or upload configuration from a file, example:

artifactories:
- password: '{{ readFile "~/.artifactory.txt" }}'
  # ...
uploads:
- password: '{{ readFile "~/.myapi.txt" }}'
  # ...

closes #5946

caarlos0 added 2 commits August 4, 2025 23:03
@caarlos0
feat(upload,artifactory): allow to set a password field, tmpl username
c10811a 
This, in conjunction with #5948, will allow users to read the password
of a given `artifactory` or `upload` configuration from a file, example:

```yaml
artifactories:
- password: '{{ readFile "~/.artifactory.txt" }}'
  # ...
uploads:
- password: '{{ readFile "~/.myapi.txt" }}'
  # ...
```

closes #5946
@caarlos0
fix: err msg
f7f3e05
@caarlos0 caarlos0 self-assigned this Aug 5, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 5, 2025 •
edited
Loading

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82d3841
Status: ✅  Deploy successful!
Preview URL: https://0219d304.goreleaser.pages.dev
Branch Preview URL: https://artifactory-http-password.goreleaser.pages.dev

View logs

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2025
@caarlos0 caarlos0 mentioned this pull request Aug 5, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.66%. Comparing base (51ee020) to head (82d3841).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/http/http.go 82.85% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5949      +/-   ##
==========================================
- Coverage   82.68%   82.66%   -0.02%     
==========================================
  Files         165      165              
  Lines       16562    16583      +21     
==========================================
+ Hits        13694    13709      +15     
- Misses       2275     2279       +4     
- Partials      593      595       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caarlos0 caarlos0 merged commit 193d2cd into main Aug 7, 2025
17 of 18 checks passed
@caarlos0 caarlos0 deleted the artifactory-http-password branch August 7, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference Artifactory Token via File
1 participant
@caarlos0