Skip to content

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 5, 2025

This should allow users to manually read secrets from files whilst configuring something, e.g.:

env:
  FOO_SECRET: '{{ mustReadFile "./secret.txt" }}'

This should allow users to manually read secrets from files whilst
configuring something, e.g.:

```go
env:
  FOO_SECRET: '{{ mustReadFile "./secret.txt" }}'
```
@caarlos0 caarlos0 self-assigned this Aug 5, 2025
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 5, 2025
Copy link

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f9ca8e
Status: ✅  Deploy successful!
Preview URL: https://74edd85e.goreleaser.pages.dev
Branch Preview URL: https://readfile-tmp.goreleaser.pages.dev

View logs

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.67%. Comparing base (29fd315) to head (7f9ca8e).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/tmpl/tmpl.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5948      +/-   ##
==========================================
- Coverage   82.67%   82.67%   -0.01%     
==========================================
  Files         165      165              
  Lines       16536    16551      +15     
==========================================
+ Hits        13671    13683      +12     
- Misses       2273     2275       +2     
- Partials      592      593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

caarlos0 added a commit that referenced this pull request Aug 5, 2025
This, in conjunction with #5948, will allow users to read the password
of a given `artifactory` or `upload` configuration from a file, example:

```yaml
artifactories:
- password: '{{ readFile "~/.artifactory.txt" }}'
  # ...
uploads:
- password: '{{ readFile "~/.myapi.txt" }}'
  # ...
```

closes #5946
@caarlos0 caarlos0 merged commit 51ee020 into main Aug 5, 2025
16 of 18 checks passed
@caarlos0 caarlos0 deleted the readfile-tmp branch August 5, 2025 22:50
caarlos0 added a commit that referenced this pull request Aug 7, 2025
#5949)

This, in conjunction with #5948, will allow users to read the password
of a given `artifactory` or `upload` configuration from a file, example:

```yaml
artifactories:
- password: '{{ readFile "~/.artifactory.txt" }}'
  # ...
uploads:
- password: '{{ readFile "~/.myapi.txt" }}'
  # ...
```

closes #5946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant