fix(shell): prevent panic on empty commands #5929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it might happen that the string is templated, but it evals to empty, in which case shell was panicking. this should fix it https://github.com/orgs/goreleaser/discussions/5928
Deploying goreleaser with
|
| Latest commit: |
1d569f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca8d8b33.goreleaser.pages.dev |
| Branch Preview URL: | https://shell-empty.goreleaser.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5929 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 165 165
Lines 16533 16536 +3
=======================================
+ Hits 13668 13671 +3
Misses 2273 2273
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it might happen that the string is templated, but it evals to empty, in which case shell was panicking.
this should fix it
https://github.com/orgs/goreleaser/discussions/5928