fix(aur): quotting when binary #5914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a shell quoting issue in the AUR package generation code where binary installation commands had unclosed quotes. The fix properly quotes shell arguments to prevent potential command injection vulnerabilities and syntax errors.
- Replaces manual string formatting with proper shell argument quoting using
%qformat specifier - Updates both binary and archive artifact installation command generation
- Includes corresponding test data update to reflect the corrected quoting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/pipe/aur/aur.go | Fixed shell command generation to use proper quoting for binary installation paths |
| internal/pipe/aur/testdata/TestRunPipeBinaryRelease.pkgbuild.golden | Updated test golden file to reflect corrected quoting in generated PKGBUILD |
Deploying goreleaser with
|
| Latest commit: |
1628b0c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ea80905.goreleaser.pages.dev |
| Branch Preview URL: | https://quote.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5914 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 165 165
Lines 16519 16519
=======================================
Hits 13654 13654
Misses 2273 2273
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed unclosed quote.