fix: exec.CommandContext #5913
fix: exec.CommandContext #5913
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates command execution throughout the codebase to use context-aware exec.CommandContext instead of exec.Command. This change enables proper cancellation and timeout handling for external command executions, improving the robustness of operations that interact with external tools like git, docker, go, and various build tools.
Key changes:
- Replace
exec.Commandcalls withexec.CommandContextto support cancellation - Update function signatures to accept context parameters where needed
- Add context imports where required
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testlib/git.go | Updated git command execution to use context |
| internal/testlib/docker.go | Added context parameter to Docker availability check |
| internal/pipe/project/project.go | Updated Go module name detection to use context |
| internal/pipe/nix/nix.go | Updated nix-hash command and interface to use context |
| Multiple test files | Updated command executions in tests to use test context |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5913 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 165 165
Lines 16519 16521 +2
=======================================
+ Hits 13654 13656 +2
Misses 2273 2273
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixed some
exec.Commandcalls to pass the context within.