fix(s3): acls not working on aws sdk v2 #5904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
| Latest commit: |
078e96b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c05c8803.goreleaser.pages.dev |
| Branch Preview URL: | https://s3-fix.goreleaser.pages.dev |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5904 +/- ##
==========================================
- Coverage 82.68% 82.65% -0.04%
==========================================
Files 165 165
Lines 16519 16519
==========================================
- Hits 13659 13654 -5
- Misses 2268 2273 +5
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates S3 ACL functionality from AWS SDK v1 to AWS SDK v2 to fix issues where ACLs were not working properly. The migration removes the forced use of AWS SDK v1 and implements proper ACL validation using the v2 SDK's type system.
- Replaces AWS SDK v1 imports with v2 equivalents for S3 operations
- Removes the forced
awssdk=v1query parameter from S3 URLs - Implements ACL validation using AWS SDK v2's
ObjectCannedACLenum types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/pipe/blob/upload.go | Migrates S3 ACL handling from AWS SDK v1 to v2 with proper validation |
| internal/pipe/blob/blob_test.go | Updates test expectations to remove awssdk=v1 parameter from URLs |
| go.mod | Changes AWS SDK dependencies from direct to indirect for v1, direct for v2 |
Comments suppressed due to low confidence (1)
internal/pipe/blob/upload.go:123
- [nitpick] The error message could be more helpful by listing the valid ACL values. Consider including the supported ACL options in the error message to guide users.
return fmt.Errorf("invalid ACL %q", conf.ACL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/orgs/goreleaser/discussions/5901