fix(cask): invalid string quoting in uninstall/zap arrays #5885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this commit does
Fixes improper string quoting in Homebrew cask
zap
arrays to ensure valid Ruby syntax in generated cask files.Previously, installing a cask with a
zap
stanza would result in an error due to unquoted strings.Example configuration
GoReleaser config (valid YAML):
Generated cask (invalid Ruby):
This results in a syntax error when running:
Error:
Actual fix
The fix updates the
groupToS
function to ensure all string values in thezap
array are properly quoted usingfmt.Sprintf("%q", l)
.Correct output:
With this fix, the cask installs correctly:
Why this change is necessary
Unquoted strings in Ruby array literals are treated as variables or invalid expressions, leading to syntax errors.
This change ensures:
Additional details
groupToS
Fixes generation bug in Homebrew cask
zap
stanzaReferences: