fix(nix): improve nix-hash check #5883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, it would give a warning when running goreleaser hc, but wouldn't actually fail the check, as the pipe was being skipped if nix-hash wasn't available. this fixes it, so it checks on run instead. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
| Latest commit: |
494cbba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f6dbfa1.goreleaser.pages.dev |
| Branch Preview URL: | https://improve-nix-hash-handling.goreleaser.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the Nix hash availability check fails at runtime instead of merely warning, by moving the availability check into Run, updating dependencies, and improving related tests.
- Switches the declared dependency from a hardcoded
"nix-hash"to thenixHashBinconstant. - Removes
hasher.Available()fromSkipand adds an explicit availability check inRunthat returns a skip error. - Updates tests: removes the old skip check, adds
TestRunSkipNoNix, and definesunavailableHasher.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/pipe/nix/nix.go | Updated Dependencies, simplified Skip, added availability check in Run |
| internal/pipe/nix/nix_test.go | Removed outdated skip test, added TestRunSkipNoNix and unavailableHasher implementation |
Comments suppressed due to low confidence (2)
internal/pipe/nix/nix.go:69
- Consider adding a unit test for
Dependenciesto assert it returns the expectednixHashBinvalue, ensuring future changes don’t break this contract.
func (Pipe) Dependencies(_ *context.Context) []string { return []string{nixHashBin} }
internal/pipe/nix/nix_test.go:691
- [nitpick] The test-only type
unavailableHashercould be renamed totestUnavailableHasherto clarify its purpose and avoid confusion with production types.
type unavailableHasher struct{}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5883 +/- ##
==========================================
- Coverage 82.71% 82.68% -0.04%
==========================================
Files 165 165
Lines 16521 16521
==========================================
- Hits 13666 13661 -5
- Misses 2262 2268 +6
+ Partials 593 592 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, it would give a warning when running goreleaser hc, but wouldn't actually fail the check, as the pipe was being skipped if nix-hash wasn't available.
this fixes it, so it checks on run instead.