fix(deps): update to lipgloss/v2 #5877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
95a9238
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d0d7076.goreleaser.pages.dev |
| Branch Preview URL: | https://lipgloss.goreleaser.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades all references to use lipgloss v2, removes legacy termenv-based color profile setup, and adjusts style definitions to the new v2 API.
- Update import paths from
github.com/charmbracelet/lipglosstogithub.com/charmbracelet/lipgloss/v2 - Remove
lipgloss.SetColorProfile(termenv.X)calls inmain.goand tests - Migrate style definitions from
AdaptiveColortolipgloss.Colorand bump go.mod to v2
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.go | Removed v1 lipgloss import and CI color-profile init via termenv |
| internal/middleware/logging/logging.go | Switched lipgloss import to v2 |
| internal/logext/writer_test.go | Dropped lipgloss & termenv imports and test color-profile setup |
| internal/logext/styles.go | Updated import and changed AdaptiveColor to lipgloss.Color |
| internal/deprecate/testdata/TestNotice.txt.golden | Whitespace change around deprecation notice (NBSP introduced) |
| internal/deprecate/deprecate_test.go | Removed lipgloss import and test color-profile calls |
| cmd/root.go | Updated lipgloss import to v2 |
| cmd/healthcheck.go | Updated lipgloss import to v2 |
| go.mod | Bumped lipgloss to v2 in require, cleaned up termenv |
Comments suppressed due to low confidence (2)
internal/logext/writer_test.go:12
- Tests no longer set a deterministic color profile, which can lead to inconsistent output across environments. Reintroduce a fixed profile using the lipgloss/v2 API (e.g., via
lipgloss.SetColorProfile) for stable, reproducible tests.
)
internal/deprecate/deprecate_test.go:11
- Removing the explicit ASCII profile setup can cause environment-dependent ANSI output in this test. Please set a known lipgloss/v2 color profile within the test to maintain consistent golden comparisons.
)
| @@ -1,3 +1,3 @@ | |||
| • first | |||
| • DEPRECATED: foo.bar_whatever: foobar should not be used anymore, check https://goreleaser.com/deprecations#foobar_whatever-foobar for more info | |||
| • DEPRECATED: foo.bar_whatever: foobar should not be used anymore, check https://goreleaser.com/deprecations#foobar_whatever-foobar for more info | |||
There was a problem hiding this comment.
This line contains non-breaking space characters (U+00A0) around the deprecation message, which may cause golden-file mismatches. Replace them with regular ASCII spaces to ensure consistent test comparisons.
Suggested change
| • DEPRECATED: foo.bar_whatever: foobar should not be used anymore, check https://goreleaser.com/deprecations#foobar_whatever-foobar for more info | |
| • DEPRECATED: foo.bar_whatever: foobar should not be used anymore, check https://goreleaser.com/deprecations#foobar_whatever-foobar for more info |
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5877 +/- ##
==========================================
- Coverage 82.75% 82.75% -0.01%
==========================================
Files 165 165
Lines 16521 16519 -2
==========================================
- Hits 13672 13670 -2
Misses 2258 2258
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading all usage to v2.
v1 is still an indirect dependency of quill.