refactor: improve commitauthor templating #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
94e5814
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc8c17c8.goreleaser.pages.dev |
| Branch Preview URL: | https://commitauthor.goreleaser.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the commit author templating logic to simplify error handling and reduce code duplication.
- Replaces individual field templating with a single ApplyAll function call
- Adjusts the function comment to indicate a new CommitAuthor instance is returned
Comments suppressed due to low confidence (2)
internal/commitauthor/author.go:15
- [nitpick] Consider clarifying the comment to indicate that the function applies templates to all fields and returns a fully templated CommitAuthor instance.
// Get templates the commit author and returns a new [config.CommitAuthor].
internal/commitauthor/author.go:34
- [nitpick] Returning an empty CommitAuthor on error may discard useful partial templating information. Consider returning the partially templated object along with an error to aid in debugging.
return config.CommitAuthor{}, err
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5858 +/- ##
=======================================
Coverage ? 82.73%
=======================================
Files ? 164
Lines ? 16497
Branches ? 0
=======================================
Hits ? 13649
Misses ? 2256
Partials ? 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small improvement in the commit author templating.