fix(cask): add test and docs for custom URL #5844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
443a18b
|
| Status: | ⚡️ Build in progress... |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances support for custom URL functionality in Homebrew casks by adding documentation and tests. Key changes include:
- Updated documentation with an example YAML snippet for configuring custom URL and headers.
- Addition of a GitHubHelper module in the test data for retrieving asset URLs and tokens.
- New test cases and a golden file to verify the custom_block_url configuration.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| www/docs/customization/homebrew_casks.md | Revised docs and example usage for custom URL configuration. |
| internal/pipe/cask/testdata/github.rb | Added GitHubHelper module for test purposes. |
| internal/pipe/cask/testdata/TestFullPipe/custom_block_url.rb.golden | Added golden file for custom_block_url testing. |
| internal/pipe/cask/cask_test.go | Extended test suite with new "custom_block_url" test case. |
Comments suppressed due to low confidence (1)
www/docs/customization/homebrew_casks.md:297
- Consider rephrasing this sentence for clarity. For example, 'The best way to support private repositories is to configure a custom block with a custom template URL and custom headers.'
a custom template URL, and custom headers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5844 +/- ##
=======================================
Coverage 82.69% 82.69%
=======================================
Files 164 164
Lines 16460 16460
=======================================
Hits 13612 13612
Misses 2256 2256
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sushichan044
suggested changes
Jun 23, 2025
Co-authored-by: Kentaro Suzuki <71284054+sushichan044@users.noreply.github.com>
|
thanks for the review @sushichan044 🙏🏻 |
caarlos0
pushed a commit
that referenced
this pull request
Jun 23, 2025
<!-- Hi, thanks for contributing! Please make sure you read our CONTRIBUTING guide. Also, add tests and the respective documentation changes as well. --> <!-- If applied, this commit will... --> Fixing the incorrect Ruby sample code I proposed for private cask releases in #5844. <!-- Why is this change being made? --> <!-- # Provide links to any relevant tickets, URLs or other resources -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on suggestions by @sushichan044