feat: place custom_block on top of cask definition
#5831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushichan044
commented
Jun 12, 2025
Comment on lines
+6
to
+8
| {{- end }} | ||
|
|
||
| {{ end }} |
There was a problem hiding this comment.
This templating ensures a clean line break is added, but only when a custom block is present.
custom_block to top in Homebrew Caskscustom_block to top in Homebrew Casks
custom_block to top in Homebrew Caskscustom_block on top of cask definition
caarlos0
approved these changes
Jun 12, 2025
custom_block on top of cask definitioncustom_block on top of cask definition
caarlos0
approved these changes
Jun 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves the
custom_blockconfiguration from the bottom to the top of generated Homebrew Cask definitions to enable dynamic URL construction through custom Ruby modules.Reason
Related Information
https://github.com/orgs/goreleaser/discussions/5817#discussion-8431103