fix(dep): update gitlab, fix use of removed function #5807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitLab API client dependency to v0.129.0 and replaces the removed UploadFile function with the new UploadProjectMarkdown method.
- Updated gitlab dependency in go.mod
- Replaced deprecated UploadFile with UploadProjectMarkdown in internal/client/gitlab.go
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/client/gitlab.go | Changed function call from UploadFile to UploadProjectMarkdown |
| go.mod | Updated gitlab API client dependency version from v0.128.0 to v0.129.0 |
Comments suppressed due to low confidence (1)
internal/client/gitlab.go:534
- Double-check that the new UploadProjectMarkdown API accepts the same parameters and returns compatible results as the removed UploadFile method. If there are any differences in behavior or return types, adjust the calling code and its handling accordingly.
projectFile, _, err := c.client.ProjectMarkdownUploads.UploadProjectMarkdown(
Deploying goreleaser with
|
| Latest commit: |
2d47ac9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5d06eea.goreleaser.pages.dev |
| Branch Preview URL: | https://gitlab.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 163 163
Lines 16310 16310
=======================================
Hits 13529 13529
Misses 2190 2190
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yes, just took a look at https://gitlab.com/gitlab-org/api/client-go/-/issues/2090 which explains the BC. Still pre-major, so it is fine and we are ready for GitLab v18 |
|
Thanks @mavogel ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently this is what we're supposed to use now - looks like it does the same thing under the hood
closes #5778
see: https://gitlab.com/gitlab-org/api/client-go/-/releases/v0.129.0