feat(cask): improve URL config #5803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
f6eed3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6264a9de.goreleaser.pages.dev |
| Branch Preview URL: | https://caskurl.goreleaser.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the Homebrew Cask URL configuration by replacing the flat url_template and url_additional fields with a unified url block that supports templating and additional download parameters.
- Update docs to show the nested
url:block with its subfields. - Define
HomebrewCaskURLinconfig.goand remove old URL fields. - Refactor internal templates and code to use the new
downloadURLtype and nested fields.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| www/docs/customization/homebrew_casks.md | Update documentation for new url: block syntax |
| pkg/config/config.go | Introduce HomebrewCaskURL struct, drop old fields |
| internal/pipe/cask/templates/*.rb | Reference element.URL.* instead of flat fields |
| internal/pipe/cask/template.go | Add downloadURL type, update releasePackage |
| internal/pipe/cask/cask.go | Populate and apply nested cfg.URL data |
| internal/pipe/cask/cask_test.go | Update tests to set and expect nested URL fields |
Comments suppressed due to low confidence (3)
pkg/config/config.go:247
- [nitpick] Consider renaming the unexported type
downloadURLto a more descriptive name (e.g.caskDownloadConfig) to clarify its purpose and avoid confusion with the standardnet/urlpackage.
type downloadURL struct {
internal/pipe/cask/templates/additional_url_params.rb:9
- [nitpick] Ruby style guides often discourage trailing commas in hash literals; consider omitting the comma after the last entry to improve compatibility with linters.
cookies: {
www/docs/customization/homebrew_casks.md:74
- Indent this comment to match the
url:block (add two more spaces) so that it clearly belongs underurl:alongsidetemplate:and other subfields.
# Templates: allowed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5803 +/- ##
=======================================
Coverage 82.93% 82.94%
=======================================
Files 163 163
Lines 16298 16307 +9
=======================================
+ Hits 13517 13526 +9
Misses 2190 2190
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one-shot this quickly so I don't forget about it
refs #5800 (comment)
closes #5797