feat: sbom.disable #5787
Merged
feat: sbom.disable #5787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an "enabled" flag in the SBOM configuration, allowing users to toggle whether SBOM generation is performed.
- Documentation added to introduce the new "enabled" field with a default of true.
- A new Enabled field is added to the SBOM configuration and integrated into the processing logic.
- Tests are extended to cover different scenarios for the Enabled setting, and the catalogTask function is refactored for clarity.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| www/docs/customization/sbom.md | Updates documentation to include the new "enabled" flag in SBOM docs. |
| pkg/config/config.go | Introduces the Enabled field with support for template and boolean values. |
| internal/pipe/sbom/sbom_test.go | Adds unit tests to verify the behavior of the Enabled flag. |
| internal/pipe/sbom/sbom.go | Implements defaulting for the Enabled flag and refactors catalogTask. |
Comments suppressed due to low confidence (1)
pkg/config/config.go:788
- The 'Enabled' field is defined as a string to support both literal booleans and template expressions. Consider adding an inline comment to clarify this design decision for future maintainers.
Enabled string `yaml:"enabled,omitempty" json:"enabled,omitempty" jsonschema:"oneof_type=string;boolean"`
Deploying goreleaser with
|
| Latest commit: |
936b187
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05a7533b.goreleaser.pages.dev |
| Branch Preview URL: | https://sbom.goreleaser.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5787 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 163 163
Lines 16292 16297 +5
=======================================
+ Hits 13511 13516 +5
Misses 2190 2190
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5786