fix(gitlab): use CI_SERVER_VERSION when available #5783
Conversation
In some cases (e.g. security reasons), the CI triggerer may not have permission to access the GitLab Version API (401 Unauthorized), and we should prioritize reading from the CI value This problem seems to be common in self-hosted instances (but official instances sometimes have problems) Signed-off-by: Coia Prant (coiaprant@gmail.com)
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the GitLab version retrieval logic to prioritize the CI_SERVER_VERSION environment variable over calling the GitLab Version API, helping avoid 401 Unauthorized errors in restricted environments.
- Prioritizes an environment variable for the GitLab version.
- Falls back to the API call when the environment variable is not set.
- Maintains error logging for debugging purposes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5783 +/- ##
=======================================
Coverage 82.93% 82.94%
=======================================
Files 161 161
Lines 15932 15935 +3
=======================================
+ Hits 13214 13217 +3
Misses 2144 2144
Partials 574 574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't know how to add a test, it doesn't seem to be the same as the existing one You can push directly to this fork :D |
|
Yes, IMO it also makes sense to use the predefine variables in the pipeline (https://docs.gitlab.com/ci/variables/predefined_variables/). |
In some cases (e.g. security reasons), the CI triggerer may not have permission to access the GitLab Version API (401 Unauthorized), and we should prioritize reading from the CI value
This problem seems to be common in self-hosted instances (but official instances sometimes have problems)