feat: homebrew casks #5780
Merged
feat: homebrew casks #5780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename cask.rb to formula.rb - change type to BrewFormula instead of BrewTap
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
SMillerDev
reviewed
May 21, 2025
Deploying goreleaser with
|
| Latest commit: |
c2eb36d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6a332ba.goreleaser.pages.dev |
| Branch Preview URL: | https://newb.goreleaser.pages.dev |
SMillerDev
reviewed
May 22, 2025
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5780 +/- ##
==========================================
- Coverage 82.93% 82.93% -0.01%
==========================================
Files 161 163 +2
Lines 15932 16292 +360
==========================================
+ Hits 13214 13511 +297
- Misses 2144 2190 +46
- Partials 574 591 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for generating Homebrew casks alongside deprecating the old brews pipe. Key changes include:
- Introduces a new
homebrew_casksconfiguration and corresponding template logic underinternal/pipe/cask - Deprecates the old
brewspipe and updates related constants and behavior - Provides golden test data for cask output and updates the main
.goreleaser.yamlto use casks
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .goreleaser.yaml | Replaced brews section with homebrew_casks |
| internal/pipe/cask/templates/linux_packages.rb | Added Linux package blocks for casks |
| internal/pipe/cask/templates/macos_packages.rb | Added macOS package blocks for casks |
| internal/pipe/cask/templates/cask.rb | Main cask template generating full Ruby casks |
| internal/pipe/cask/template.go | Data struct and embedding for cask templates |
| internal/pipe/brew/brew.go & brew_test.go | Deprecation notices and updated constants |
| internal/artifact/artifact.go | Introduced BrewCask type alongside BrewFormula |
| internal/pipe/cask/testdata/TestFullPipe/*.golden | Golden files for cask pipeline tests |
Comments suppressed due to low confidence (3)
.goreleaser.yaml:221
- The YAML key
homebrew_casksmay not align with the Go struct fieldHomebrewCask(singular). Verify the mapping or rename the key to match the struct name.
homebrew_casks:
internal/pipe/cask/template.go:1
- [nitpick] There are no unit tests for the new cask pipe implementation. Consider adding tests under
internal/pipe/caskto validate template rendering and publishing workflows.
package cask
internal/pipe/cask/templates/linux_packages.rb:7
- [nitpick] The ARM block nesting is misaligned: the
ifinside this branch doesn't match a correspondingdo/endfor anon_armblock. Consider usingon_arm do ... endconsistently and ensure each conditional block is properly closed.
{{- else if eq $element.Arch "arm" }}
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
and some other small, unrelated changes
|
Gonna merge this so it gets in the next nightly builds! Thanks so much for all the help and support here @SMillerDev! Really appreciate it <3 |
|
Thanks for the work here! Very happy to see the situation improved for both Homebrew and Goreleaser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
homebrew_casksroot configurationbrews/Formulafolder, new default should beCaskcloses #5607
closes #5594
refs https://github.com/Homebrew/brew/blob/master/docs/Cask-Cookbook.md