fix(init): handle CRLF line endings in gitignore #5775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
May 19, 2025
|
This looks good, thanks! Gonna wait for CI and merge if good :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
==========================================
- Coverage 82.93% 82.92% -0.02%
==========================================
Files 161 161
Lines 15925 15932 +7
==========================================
+ Hits 13207 13211 +4
- Misses 2144 2146 +2
- Partials 574 575 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the
goreleaser initcommand when modifying.gitignorefiles:.gitignorefile contains CRLF line endings, the command would incorrectly add duplicatedist/entries.gitignorefile doesn't end with a newline, the new entries would be appended on the same line, causing incorrect formatting