fix(bun,deno): duplicated build flags #5771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with duplicated build flags in both the Deno and Bun builders by removing an earlier, redundant flag append and ensuring the proper sequence of command arguments.
- Removed duplicate flag appending in the Deno builder
- Removed duplicate flag appending in the Bun builder
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/builders/deno/build.go | Removed duplicate command flag appends; now using a single append with "--target", "--output", and build.Main. |
| internal/builders/bun/build.go | Removed duplicate command flag appends; now using a single append with "--target", "--outfile", and build.Main. |
Comments suppressed due to low confidence (2)
internal/builders/deno/build.go:127
- Ensure that replacing the earlier append using build.Flags with the later use of flags does not unintentionally omit any necessary flags required for the build configuration.
command = append(
internal/builders/bun/build.go:140
- Confirm that the updated flag append logic using flags (and the use of '--outfile' for Bun) correctly replaces the duplicated logic, ensuring no essential build flags are lost in the process.
command = append(
Deploying goreleaser with
|
| Latest commit: |
07a63e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7b65fe4.goreleaser.pages.dev |
| Branch Preview URL: | https://deno-bun-build-flags.goreleaser.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found while looking into https://github.com/orgs/goreleaser/discussions/5763