fix: increase default timeout #5726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think 30m is not enough for most big-enough projects these days, especially considering Rust builds are slower. IMHO it's fine to increase to 1hr.
There was a problem hiding this comment.
Pull Request Overview
This PR increases the default timeout value from 30 minutes to 1 hour for both the release and build processes to better accommodate longer build times.
- Updated release command timeout in cmd/release.go
- Updated build command timeout in cmd/build.go
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/release.go | Changed timeout from 30 minutes to 1 hour for the release process |
| cmd/build.go | Changed timeout from 30 minutes to 1 hour for the build process |
Deploying goreleaser with
|
| Latest commit: |
46931f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://94aa8953.goreleaser.pages.dev |
| Branch Preview URL: | https://timeout.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5726 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 160 160
Lines 15771 15771
=======================================
Hits 13081 13081
Misses 2124 2124
Partials 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think 30m is not enough for most big-enough projects these days, especially considering Rust builds are slower.
IMHO it's fine to increase to 1hr.