Skip to content

fix: group by platform should consider abi if available #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

fix: group by platform should consider abi if available #5723

merged 2 commits into from
Apr 15, 2025

Conversation

caarlos0
Copy link
Member

closes #5722

@caarlos0 caarlos0 added the bug Something isn't working label Apr 15, 2025
@caarlos0 caarlos0 requested a review from Copilot April 15, 2025 02:18
@caarlos0 caarlos0 self-assigned this Apr 15, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2025
@caarlos0 caarlos0 mentioned this pull request Apr 15, 2025
Closed
Copilot
Copilot AI reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

internal/pipe/archive/archive.go:135

  • Changing the log level from Debugf to Infof might lead to excessive logging in production if not intended. Please confirm that this change is deliberate.
log.Infof("group %s has %d binaries", group, len(artifacts))

internal/artifact/artifact.go:442

  • Concatenating fields directly may lead to ambiguous grouping keys if any field values overlap; consider adding a delimiter between fields to ensure unambiguous group keys.
fullplat := plat + abi + a.Goarm + a.Gomips + a.Goamd64

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 15, 2025 •
edited
Loading

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89b2a9d
Status:⚡️  Build in progress...

View logs

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (5281fed) to head (89b2a9d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5723   +/-   ##
=======================================
  Coverage   82.93%   82.94%           
=======================================
  Files         160      160           
  Lines       15765    15771    +6     
=======================================
+ Hits        13075    13081    +6     
  Misses       2124     2124           
  Partials      566      566

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

caarlos0
caarlos0 commented Apr 15, 2025
View reviewed changes
@caarlos0 caarlos0 merged commit 1104dca into main Apr 15, 2025
13 of 14 checks passed
@caarlos0 caarlos0 deleted the abi-grouping branch April 15, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bad artifact grouping when building zig with multiple abis
1 participant
@caarlos0