fix: upx properly handle skips #5720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying goreleaser with
|
| Latest commit: |
263d1f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96fada05.goreleaser.pages.dev |
| Branch Preview URL: | https://upx-fix.goreleaser.pages.dev |
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- internal/pipe/upx/testdata/fakeupx: Language not supported
Comments suppressed due to low confidence (1)
internal/pipe/upx/upx.go:51
- [nitpick] The removal of launching a separate goroutine for each binary compressOne call now processes them sequentially. Confirm that this change is intentional, as it may impact performance when handling multiple binaries concurrently.
if err := compressOne(ctx, upx, bin); err != nil {
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- internal/pipe/upx/testdata/fakeupx: Language not supported
- www/docs/static/schema-pro.json: Language not supported
Comments suppressed due to low confidence (2)
internal/pipe/upx/upx.go:37
- The change from using semerrgroup.NewSkipAware to semerrgroup.New combined with a separate SkipMemento may affect the concurrency and skip aggregation behavior; please verify that this change fully aligns with the intended skip handling logic or add a clarifying comment.
g := semerrgroup.New(ctx.Parallelism)
internal/pipe/upx/upx.go:38
- [nitpick] Consider adding an inline comment to explain the purpose of using SkipMemento for accumulating skip events instead of returning immediately; this helps maintain clarity on the skip handling overall.
skips := pipe.SkipMemento{}
caarlos0
commented
Apr 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5720 +/- ##
==========================================
- Coverage 82.99% 82.93% -0.07%
==========================================
Files 160 160
Lines 15758 15765 +7
==========================================
- Hits 13079 13075 -4
- Misses 2115 2124 +9
- Partials 564 566 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5719
upxfor real andgo build